Skip to content

Improve update error log cases #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

Improve update error log cases #40

merged 1 commit into from
Aug 19, 2025

Conversation

@SniperSister
Copy link
Collaborator

@SniperSister SniperSister commented Aug 19, 2025

Summary of Changes

  • Successful errors aren't logged after the archive anymore, but only after the update has been completed with all steps
  • Exceptions caused during the "failed update" notification call caused the "failed" method to break before the debug information had been written to the database

Testing Instructions

  • Code Review
  • Verify tests still work

@SniperSister SniperSister requested a review from rdeutz August 19, 2025 06:26
@HLeithner HLeithner self-requested a review August 19, 2025 08:23
@SniperSister SniperSister merged commit f183158 into main Aug 19, 2025
3 checks passed
@SniperSister SniperSister deleted the feature/improve-error-loggin branch November 18, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HLeithner HLeithner HLeithner approved these changes

@rdeutz rdeutz Awaiting requested review from rdeutz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SniperSister @HLeithner